Skip to content

Add support for React 19#269

Closed
soasada wants to merge 2 commits into
jsardev:masterfrom
soasada:master
Closed

Add support for React 19#269
soasada wants to merge 2 commits into
jsardev:masterfrom
soasada:master

Conversation

@soasada
Copy link
Copy Markdown

@soasada soasada commented Oct 31, 2025

This PR tries to close #268.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: 723403e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jsardev
jsardev requested changes Nov 9, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@jsardev jsardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! A few comments 🙏

Comment thread .gitignore
Copy link
Copy Markdown
Owner

@jsardev jsardev Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: package-lock should not be in here as we use yarn
suggestion: directories like .idea should be in everyone's personal global configs, not in repositories as it's a personal preference, not something related to the codebase

Comment thread lib/index.tsx
@@ -285,7 +285,9 @@ class Reaptcha extends Component<Props, State> {
key={this.state.instanceKey}
id={this.props.id}
className={this.props.className}
ref={e => (this.container = e)}
ref={e => {
Copy link
Copy Markdown
Owner

@jsardev jsardev Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: please leave the formatting as it was 🙏

@dimaaan dimaaan mentioned this pull request Jan 26, 2026
Open
@jsardev
Copy link
Copy Markdown
Owner

jsardev commented Jan 28, 2026 •
edited
Loading

Closing in favor of #270

@jsardev jsardev closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsardev jsardev jsardev requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reaptcha does not support react 19

2 participants

@soasada @jsardev