Fix references in README#41
Closed
williamgrosset wants to merge 1 commit intojstejada:masterfrom
williamgrosset:master
Closed
Fix references in README#41williamgrosset wants to merge 1 commit intojstejada:masterfrom williamgrosset:master
williamgrosset wants to merge 1 commit intojstejada:masterfrom
williamgrosset:master
Conversation
jstejada
requested changes
Mar 11, 2018
| } | ||
| ``` | ||
|
|
||
| #### UMD module: |
Owner
There was a problem hiding this comment.
hey! I'm not sure why we removed this. Is the file not available in the npm package?
| blink. To include it, you must include | ||
| [`dist/Typist.css`](/dist/Typist.css) in your build. | ||
|
|
||
| [`src/Cursor.scss`](/src/Cursor.scss) in your build. |
Owner
There was a problem hiding this comment.
hmmm, I'm not sure this is correct. we were previously pointing people to the compiled .css version, right?
Author
|
Hey @jstejada — don't worry about this PR. I had build issues when I ran this last night, and assumed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
This PR introduces changes to the
README.md:Also, I'm working with a project that's not using
sass, so I just used the compiled version directly:Thanks again for the package — cheers!