meta/sql: optimizate the rmr emptyDir #6457
Open
+414
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6457 +/- ##
===========================================
+ Coverage 22.29% 55.55% +33.26%
===========================================
Files 30 167 +137
Lines 20446 51389 +30943
===========================================
+ Hits 4558 28551 +23993
- Misses 15377 19728 +4351
- Partials 511 3110 +2599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/meta/sql.go
Outdated
|
|
||
| info := entryInfo{e: e, trash: trash} | ||
| n := node{Inode: e.Inode} | ||
| ok, err := s.ForUpdate().Get(&n) |
Contributor
There was a problem hiding this comment.
可以合并的sql语句都处理下，有挺大提升空间
Xuyuchao-juice
force-pushed
the
xyc_rmr
branch
from
7b43edb to
f7335ae
Compare
Xuyuchao-juice
force-pushed
the
xyc_rmr
branch
from
f7335ae to
8676dc8
Compare
Xuyuchao-juice
changed the title
Xuyuchao-juice
changed the title
Signed-off-by: jiefenghuang <[email protected]>
| q := s.Table(&edge{}) | ||
| for i, e := range edges { | ||
| if i == 0 { | ||
| q = q.Where("(parent = ? AND name = ?)", e.Parent, e.Name) |
| } | ||
|
|
||
| seen := make(map[Ino]uint32) | ||
| for i := range entryInfos { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How about this PR
New low-level doEmptyDir interface, to batch delete files, can optimize metadata operations.
Test Reslut:
Delete a directory with 10,000 empty files
Multilevel directory deletion test（About 11,000 directories and 110,000 files）
