meta: Replace doReaddir with DirHandler for batch fetching in cloneEntry #6469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change:
The original implementation used doReaddir to load all directory entries at once, which causes performance issues and high memory pressure when cloning large directories. This leads to slow metadata operations, negative ETA values, and progress staying at 0 for extended periods.
How it's implemented:
Replace the single doReaddir call with DirHandler's List method to fetch directory entries in batches. The implementation maintains the directory-first processing strategy (directories before files) to maximize parallelism, while using incremental offset-based fetching to reduce per-query overhead and improve overall performance for large directories.