fix: restore local multi-arch pack support#106
Closed
wallyworld wants to merge 1 commit intojuju:3.6from
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103 took away (accidentally?) the ability to locally pack the charm for multiple arches.
54bd27d
This PR restores that ability. It assumes we want to build on amd64 as did the original.
It seems remote-build (to build on launchpad) is broken?
So for now we'll need to build locally and upload and release by hand, or maybe I'm holding remote-build wrongly.
QA
Also note that the running the github action to build and test the charm now correctly puts charms in each arch. You will note that builds of other PRs before this fix only made it to amd64. Maybe there's some secret sauce I'm not aware of but not sure of how we planned to publish across all arches?