Revert "test: Use XCTestExpectation in PerformanceTracker (getsentry#5830)"

This reverts commit 93c4d68.

Author: philipsawyerdd

Tests/SentryTests/Integrations/Performance/SentryPerformanceTrackerTests.swift

@@ -287,21 +287,18 @@ class SentryPerformanceTrackerTests: XCTestCase {
         sut.activateSpan(spanId) {
 
             let queue = DispatchQueue(label: "SentryPerformanceTrackerTests", attributes: [.concurrent, .initiallyInactive])
+            let group = DispatchGroup()
 
-            let loopCount = 5_000
-            let expectation = self.expectation(description: "Start spans in parallel")
-            expectation.expectedFulfillmentCount = loopCount
-            expectation.assertForOverFulfill = true
-
-            for _ in 0 ..< loopCount {
+            for _ in 0 ..< 5_000 {
+                group.enter()
                 queue.async {
                     _ = self.startSpan(tracker: sut)
-                    expectation.fulfill()
+                    group.leave()
                 }
             }
 
             queue.activate()
-            self.wait(for: [expectation], timeout: 10.0)
+            group.wait()
         }
         let spans = getSpans(tracker: sut)
         XCTAssertEqual(spans.count, 5_001)
@@ -316,23 +313,20 @@ class SentryPerformanceTrackerTests: XCTestCase {
         sut.activateSpan(spanId) {
 
             let queue = DispatchQueue(label: "SentryPerformanceTrackerTests", attributes: [.concurrent, .initiallyInactive])
-
-            let loopCount = 50
-            let expectation = self.expectation(description: "Create child spans in parallel")
-            expectation.expectedFulfillmentCount = loopCount
-            expectation.assertForOverFulfill = true
-
-            for _ in 0 ..< loopCount {
+            let group = DispatchGroup()
+            
+            for _ in 0 ..< 50 {
+                group.enter()
                 queue.async {
                     let childId = self.startSpan(tracker: sut)
                     sut.activateSpan(childId) {
                     }
-                    expectation.fulfill()
+                    group.leave()
                 }
             }
 
             queue.activate()
-            self.wait(for: [expectation], timeout: 10.0)
+            group.wait()
         }
 
         let stack = getStack(tracker: sut)