Skip to content

Fix missing escaping in media.php #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomjn wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix missing escaping in media.php #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc41932
fixes 4 unescaped variables embedded in 2 strings
tomjn Aug 17, 2017
17f85d1
swaps the quotes around and fixes a stray single quote
tomjn Aug 17, 2017
e7619cd
readds a missing closing quote
tomjn Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jw-player/include/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ function jwplayer_media_sync_form_html( $media ) {
$html .= 'Disabling sync is currently not possible, because it would break your media embeds. ';
$html .= '</p>';
} else {
$html .= "<label for='attachments[$media->ID][jwplayer_media_sync]'>";
$html .= "<input type='checkbox' value='sync' name='attachments[$media->ID][jwplayer_media_sync]' />";
$html .= '<label for="'.esc_attr( 'attachments['.$media->ID.'][jwplayer_media_sync]').'">';
$html .= '<input type="checkbox" value="sync" name="'.esc_attr( 'attachments['.$media->ID.'][jwplayer_media_sync]' ).'" />';
$html .= '&nbsp;&nbsp;Sync to JW Player';
$html .= '</label>';
$html .= '<p class="description">';
Expand Down