[Backport release-1.34] Retry resync in etcd member reconciler #6616
+86
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 3ea36f4)
Instead of resyncing inside the watch, do it from a separate goroutine. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 31d2fcc)
Previously, a failed resync attempt was not retried automatically. It was only ever re-triggered by a new update to the EtcdMember resources. Implement a retry after ten seconds whenever the resync didn't finish without any issues. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit b887251)
16 tasks
ncopa
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.34, triggered by a label in #6608.See .