ref: complete ts migration#4
Open
kak-rastoki wants to merge 1 commit intomainfrom
Open
Conversation
gennady-bars
approved these changes
May 6, 2026
There was a problem hiding this comment.
Поздравляю! Ваша работа принята.
Вы отлично потрудились.
- Отлично, что знаете про тип
KeyboardEventдля событий клавиатуры - Хорошая типизация функций и компонентов
- Отлично типизировали хуки
useSelectorиuseDispatch - Отлично типизировали стейт, диспатч
Можно лучше
- Есть небольшая хитрость: можно всегда проверить, какой тип у функции или события. Для этого нужно навести мышкой на атрибут
onChange,onSubmit,onClickи тд. Там высветится типизация того, что принимают эти атрибуты.
Comment on lines
+25
to
+26
| export const useAppDispatch = useDispatch.withTypes<AppDispatch>(); | ||
| export const useAppSelector = useSelector.withTypes<RootState>(); |
There was a problem hiding this comment.
- Отлично типизировали хуки
useSelectorиuseDispatch - Отлично типизировали стейт, диспатч
| const [forgotPassword, { isLoading, error }] = useForgotPasswordMutation(); | ||
|
|
||
| const handleSubmit = async (e) => { | ||
| const handleSubmit = async (e: FormEvent<HTMLFormElement>): Promise<void> => { |
There was a problem hiding this comment.
FormEvent уже устарел, поэтому лучше использовать другой (новый тип): SubmitEvent
const handleSubmit = async (e: SubmitEvent): Promise<void> => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Натипизировал