Fixing exceptions when attribute contains no value#1056
Open
Chopinsky wants to merge 3 commits intokangax:gh-pagesfrom
Chopinsky:gh-pages
Open
Fixing exceptions when attribute contains no value#1056Chopinsky wants to merge 3 commits intokangax:gh-pagesfrom Chopinsky:gh-pages
Chopinsky wants to merge 3 commits intokangax:gh-pagesfrom
Chopinsky:gh-pages
Conversation
DanielRuf
suggested changes
Feb 2, 2020
reverting from a more sweeping change where any attrValue not of the type of 'string' is treated as a blank entry.
lucalves
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address the exception being thrown if the target html file contains
linktags whosetypeattribute is defined but without a value.For example, when using the plugin with webpack, encountering the following
linktag:<link href="https://somecdn.com/favicon/favicon.png" rel="icon" type>in a html file will crash the build process because of this exception:
TypeError: Cannot read property 'toLowerCase' of undefined.With this fix, we will treat the undefined attribute value as a blank string value, i.e. it will be equivalent as the
linktag below:<link href="https://somecdn.com/favicon/favicon.png" rel="icon" type="">.