Himmelblau requirements#39
Merged
Merged
Conversation
Firstyear
force-pushed
the
20250520-himmelblau-reqs
branch
from
2f7db08 to
faaf4e7
Compare
Firstyear
force-pushed
the
20250520-himmelblau-reqs
branch
from
faaf4e7 to
14b3607
Compare
dmulder
approved these changes
Jun 25, 2025
Collaborator
dmulder
left a comment
dmulder
left a comment
There was a problem hiding this comment.
LGTM.
These build with my test code, and basic functionality tests succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature enablement for himmelblau so that they can upgrade to the latest hsm-crypto and compact-jwt.