Automated cherry pick of #6838: fix: should use nodesgvr when querying node metrics

[vie-serendipity]

Cherry pick of #6838 on release-1.12.
#6838: fix: should use nodesgvr when querying node metrics
For details on the cherry pick process, see the cherry pick requests page.

`karmada-metrics-adapter`: Fixed a panic when querying node metrics by name. This was caused by using the wrong GroupVersionResource (PodsGVR instead of NodesGVR) when creating a lister, which led to a type assertion failure.

[gemini-code-assist]

Summary of Changes

Hello @vie-serendipity, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated cherry-pick to backport a critical fix to the release-1.12 branch. The change addresses an error in the metrics adapter where node metrics were incorrectly referenced, ensuring that the system now correctly identifies and queries node resources for metric collection.

Highlights

• Metrics Query Fix: Corrected an issue in the resource metrics provider where node metrics were being queried using the PodsGVR (GroupVersionResource) instead of the appropriate NodesGVR. This ensures accurate retrieval of node-specific metrics.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign poor12 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/metricsadapter/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Code Review

This pull request is a cherry-pick that fixes a critical bug in the queryNodeMetricsByName function. The original code was incorrectly using PodsGVR instead of NodesGVR when creating a lister for nodes. This would have caused a runtime panic due to a failed type assertion on a subsequent line. The change correctly uses NodesGVR, resolving the issue. The fix is correct and necessary.

[RainbowMango]

@vie-serendipity We don't maintain release-1.12 anymore. Is there any particular reason that you want to do this on this release?

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.45%. Comparing base (2b770a2) to head (8a6d396).

Files with missing lines	Patch %	Lines
pkg/metricsadapter/provider/resourcemetrics.go	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.12    #6892      +/-   ##
================================================
+ Coverage         46.54%   47.45%   +0.91%     
================================================
  Files               665      665              
  Lines             55102    44905   -10197     
================================================
- Hits              25645    21311    -4334     
+ Misses            27819    21958    -5861     
+ Partials           1638     1636       -2     

Flag	Coverage Δ
unittests	47.45% <0.00%> (+0.91%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vie-serendipity]

@RainbowMango OK, I will close this pr.