Skip to content

Conversation

@zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
We introduced support for resource quota calculation for multi-components in #6701. However, further adaptation is needed for multi-components scheduling. For example, the current scheduling result for multi-components does not include replicas, so the existing logic skips quota calculation entirely—this needs to be updated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: Enabled federated resource quota calculation for multi-component scheduling.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 19, 2025
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the federated resource quota mechanism to properly account for multi-component applications during scheduling. It addresses a gap where resource quota calculations might be skipped for multi-component resources if replica information was not explicitly present in the scheduling result, or if the scheduled clusters changed. The changes ensure that resource usage is accurately tracked for complex, distributed applications managed by Karmada.

Highlights

  • Enhanced Quota Relevance Check: The system now correctly identifies when a resource binding with multiple components requires a quota recalculation, specifically when its scheduled clusters change.
  • New Cluster Change Detection: A dedicated function isScheduledClusterChanged has been introduced to accurately determine if the set of clusters a resource is scheduled on has been modified.
  • Multi-Component Quota E2E Test: A new end-to-end test suite has been added to validate the accurate calculation of federated resource quotas for multi-component applications, using a FlinkDeployment as an example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for federated resource quota calculation for multi-component scheduling. The main change correctly triggers quota validation when scheduled clusters change for a resource with multiple components, which is necessary as replica counts are not used for them in this scenario. The implementation appears correct, and the addition of a new e2e test to verify this behavior is a great improvement. I have one suggestion to make the new test code more robust.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.45%. Comparing base (181bffc) to head (c012888).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
pkg/webhook/resourcebinding/validating.go 50.00% 3 Missing and 3 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6934      +/-   ##
==========================================
+ Coverage   46.43%   46.45%   +0.02%     
==========================================
  Files         698      698              
  Lines       47787    47808      +21     
==========================================
+ Hits        22189    22211      +22     
+ Misses      23929    23928       -1     
  Partials     1669     1669              
Flag Coverage Δ
unittests 46.45% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhzhuang-zju
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for federated resource quota calculation for multi-component scheduling. This is achieved by introducing a check for changes in scheduled clusters for multi-component workloads, which then triggers a quota recalculation. A comprehensive e2e test is also added to validate the quota usage calculation for a FlinkDeployment custom resource. The overall approach is sound, but I've identified a potential bug in how cluster changes are detected and provided a suggestion for a more robust implementation.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@karmada-bot karmada-bot merged commit 6a6fb11 into karmada-io:master Nov 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants