Automated cherry pick of #6723, #6755, #6934

[zhzhuang-zju]

Cherry pick of #6723, #6755, #6934 on release-1.15.
#6723: fix the issue that rbSpec.Components is not updated when the
For details on the cherry pick process, see the cherry pick requests page.
#6755: fix the issue that resourcebinding validating webhook may panic when ReplicaRequirements of a Component in rbSpec.Components is nil.
#6934: enable federated resource quota calculation for multi-component scheduling.

`karmada-controller-manager`: Fixed the issue that `rbSpec.Components` is not updated when the template is updated.
`karmada-webhook`: Fixed the issue that resourcebinding validating webhook may panic when ReplicaRequirements of a Component in rbSpec.Components is nil.
`karmada-webhook`: Fixed the issue where the `FederatedResourceQuota` was not promptly updated when a multi-component workload generated new scheduling results.

[gemini-code-assist]

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated cherry-pick aimed at correcting a specific data handling oversight within the resource detection and policy application logic. It ensures that a critical field, Components, is consistently updated when resource binding policies are applied, thereby preventing unexpected behavior or data discrepancies in the system.

Highlights

• Bug Fix: Resolved an issue where the rbSpec.Components field was not being updated correctly when applying policies, leading to potential data inconsistencies.
• Policy Application Logic: Ensured that the Components field is properly copied during the ApplyPolicy and ApplyClusterPolicy operations within the resource detector.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where rbSpec.Components was not being updated when applying a policy. The change adds the missing line to copy the Components field in three places.

During the review, I noticed that the code for updating the binding specification is duplicated across ApplyPolicy and ApplyClusterPolicy. This has led to an inconsistency where the update logic for ClusterResourceBinding is missing the PropagateDeps and SchedulePriority fields. I've provided a comment with a code suggestion to fix this bug and another comment recommending refactoring the duplicated logic into a helper function to improve maintainability and prevent similar issues in the future.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.08%. Comparing base (5ace602) to head (d218ec2).

Files with missing lines	Patch %	Lines
pkg/webhook/resourcebinding/validating.go	79.16%	2 Missing and 3 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.15    #6954      +/-   ##
================================================
+ Coverage         46.07%   46.08%   +0.01%     
================================================
  Files               688      688              
  Lines             46580    46603      +23     
================================================
+ Hits              21461    21479      +18     
- Misses            23508    23513       +5     
  Partials           1611     1611              

Flag	Coverage Δ
unittests	46.08% <81.48%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zhzhuang-zju]

/retest

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment