fix: birthday not yet reached this year test

[Lach-dev]

Description:

The test case "Birthday not yet reached this year" had an issue. It will always fail in December due to the month overflow making it January. The logic creates a future month but doesn't properly handle the year calculation when adjusting for birth year.

Changes:

• Added year increment when December

Checklist:

• Tests Passing: Verify by running make test.
• Golint Passing: Confirm by running make lint.

Summary by CodeRabbit

• Tests
  • Improved test reliability for age calculation logic by fixing date handling in edge cases.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request fixes a test bug in TestCalculateAge where constructing a birth date using month arithmetic (testTime.Month()%12+1) could produce invalid months. A helper function with overflow handling now properly increments months and wraps to January while incrementing the year when necessary.

Changes

Cohort / File(s)	Summary
Test Logic Fix time/time_test.go	Updated "Birthday not yet reached this year" test case to use a helper function that safely increments months with overflow handling, replacing direct modulo arithmetic that could generate invalid month values

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• fixed calculate age test cases and function logic #117: Modifies the same TestCalculateAge logic in time/time_test.go for handling birth date and "birthday not yet reached" checks
• Fixed time package tests #87: Also modifies time/time_test.go's TestCalculateAge function, including how current time and birth date are constructed

Suggested reviewers

• shahzadhaider1

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically describes the main change: fixing a bug in the 'Birthday not yet reached this year' test case where month overflow handling was incorrect.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

time/time_test.go (1)

498-506: LGTM! Clean fix for the December overflow bug.

The helper function correctly handles the month overflow by wrapping to January and incrementing the birth year. This ensures that when tests run in December, the calculated birth date is in January of the following year, which properly represents a "future" birthday.

Consider using the time.December constant for improved readability:

-    if futureMonth > 12 {
+    if futureMonth > time.December {
         futureMonth = 1
         year++ // If we overflow to next year, change birth year
     }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63eaeb1 and 08643e8.

📒 Files selected for processing (1)

• time/time_test.go (1 hunks)

🔇 Additional comments (1)

time/time_test.go (1)

513-513: Consider verifying the month arithmetic for edge cases.

Line 513 uses (testTime.Month()+11)%12+1 for calculating the previous month, which has a similar pattern to the bug fixed in this PR. When testTime is January, this formula produces January (not December of the previous year), which might not correctly represent the intended behavior for the "Birthday already passed this year" test case.