Skip to content

chore: upgrade to Nitro 0.35.0#324

Merged
robertherber merged 3 commits intokingstinct:masterfrom
AlshehriAli0:feat/nitro-0.35-upgrade
Mar 9, 2026
Merged

chore: upgrade to Nitro 0.35.0#324
robertherber merged 3 commits intokingstinct:masterfrom
AlshehriAli0:feat/nitro-0.35-upgrade

Conversation

@AlshehriAli0
Copy link
Contributor

@AlshehriAli0 AlshehriAli0 commented Mar 5, 2026

Upgrades to Nitro 0.35 which includes critical memory leak fix for Kotlin HybridObjects. All specs regenerated and tested on iOS Simulator.

Note: next version (that will have this change) should be at least minor or maybe major since nitro 35 brings breaking changes, docs have to be also updated later to show the compatibility between versions

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

🦋 Changeset detected

Latest commit: 41cc2ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kingstinct/react-native-healthkit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlshehriAli0
Copy link
Contributor Author

AlshehriAli0 commented Mar 5, 2026

@robertherber, also for the fix we applied previously for the build problem its resolved in xcode 26.3, we can safely remove all related code to it and just make sure the build machine uses 26.3 and we good

@robertherber robertherber requested a review from Copilot March 5, 2026 17:30
Updated the package version for Nitro to 0.35.0.
@robertherber
Copy link
Member

Appreciate it @AlshehriAli0! For some reason I can't seem to trigger the workflows on this PR - could it be a setting in your repo?

@AlshehriAli0
Copy link
Contributor Author

Appreciate it @AlshehriAli0! For some reason I can't seem to trigger the workflows on this PR - could it be a setting in your repo?

Dont mention it. For the workflows, seems like github actions is having an outage

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

Open in StackBlitz

npm i https://pkg.pr.new/kingstinct/react-native-healthkit/@kingstinct/react-native-healthkit@324

commit: 41cc2ab

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@AlshehriAli0
Copy link
Contributor Author

Can you check again please @robertherber

@robertherber robertherber merged commit 9151556 into kingstinct:master Mar 9, 2026
7 checks passed
@robertherber
Copy link
Member

Thanks @AlshehriAli0! It's now merged and released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants