better Chinese translation (both Traditional and Simplified) #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2025 07:59
* add quick language switch on Nav Bar ( only affect site language, which only affect the core CMP popup demo ) to quickly test translations from the core demo which has more text. * also add some minimal CSS to support it.
… supported (i18n translated) language variant and failback to 2 characters language code if not supported.
e.g. if the top html tag is
<html lang="EN-CA">
it will first test if "en-ca" is translated , then check if "en" is supported, and correct i18n translation will be used.
this behavior consistent with klaro.show() command.
change <html lang="XX-XX"> then call klaro.show() was working, but auto detection was not. so this fix sync the behavior
* about hu.yml translation
it cause error
YAMLParseError: Nested mappings are not allowed in compact mappings at line 54, column 26:
descriptionEmptyStore: Amennyiben beleegyezik ebbe a szolgáltatásba, el kell …
just wrapped with single quote to skip the error as I did not understand that language
Author
|
another functional changes Ensure correctly detect language variant at first load, and only load supported (i18n translated) language variant and failback to 2 characters language code if not supported. e.g. if the top html tag is it will first test if "en-ca" is translated , then check if "en" is supported, and correct i18n translation will be used. change then call klaro.show() was working, but auto detection was not. so this fix sync the behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick preview as follow:
