Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 12, 2025

Fixes #4484

  • Using the server address provided by libkiwix instead of the custom one(Created in Android).
  • Upgraded to libkiwix 2.4.0.
  • Fixed: InitialDownloadTest, and DownloadTest were failing on API level 35.
screen-20251112-225231.mp4

* Using the server address provided by libkiwix instead of the custom one(Created in Android).
* Upgraded to libkiwix `2.4.0`.
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.21%. Comparing base (5142ea1) to head (d01e2dc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/kiwix/kiwixmobile/webserver/KiwixServer.kt 50.00% 1 Missing and 1 partial ⚠️
...wixmobile/webserver/wifi_hotspot/HotspotService.kt 0.00% 0 Missing and 2 partials ⚠️
...org/kiwix/kiwixmobile/webserver/WebServerHelper.kt 0.00% 0 Missing and 1 partial ⚠️
...org/kiwix/kiwixmobile/webserver/ZimHostFragment.kt 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4487      +/-   ##
============================================
- Coverage     58.49%   58.21%   -0.29%     
+ Complexity     1464     1460       -4     
============================================
  Files           327      327              
  Lines         17057    17063       +6     
  Branches       2115     2116       +1     
============================================
- Hits           9978     9933      -45     
- Misses         5676     5727      +51     
  Partials       1403     1403              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42
Copy link
Collaborator

Seems we still have a problem with the CI!

@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 Now, CI is green.

@kelson42 kelson42 merged commit 46c97a3 into main Nov 13, 2025
34 of 35 checks passed
@kelson42 kelson42 deleted the Fixes#4484 branch November 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use libkiwix provided hotspot server address

4 participants