Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

Fixes #4492

  • The crash occurred because the fragment was not visible on the window when attempting to stop the read-aloud service. We improved the service-stopping logic to ensure it is handled correctly when the Compose view is disposed.
  • Applied similar improvements to other fragments with the same pattern, ensuring all listeners, callbacks, and services are properly cleaned up at the appropriate lifecycle moment.

…tartNotAllowedException`.

* The crash occurred because the fragment was not visible on the window when attempting to stop the read-aloud service. We improved the service-stopping logic to ensure it is handled correctly when the Compose view is disposed.
* Applied similar improvements to other fragments with the same pattern, ensuring all listeners, callbacks, and services are properly cleaned up at the appropriate lifecycle moment.
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.90%. Comparing base (7b8f544) to head (b2de21d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kiwixmobile/core/main/reader/CoreReaderFragment.kt 68.42% 5 Missing and 1 partial ⚠️
.../destination/library/local/LocalLibraryFragment.kt 83.33% 1 Missing ⚠️
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4493      +/-   ##
============================================
+ Coverage     58.88%   58.90%   +0.02%     
- Complexity     1476     1487      +11     
============================================
  Files           320      320              
  Lines         17055    17081      +26     
  Branches       2128     2128              
============================================
+ Hits          10043    10062      +19     
- Misses         5595     5616      +21     
+ Partials       1417     1403      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42 kelson42 merged commit 987aebf into main Nov 14, 2025
35 checks passed
@kelson42 kelson42 deleted the Fixes#4492 branch November 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlayStore reported a crash for android.app.BackgroundServiceStartNotAllowedException.

4 participants