Improved the startup behavior of DownloadMonitorService.
#4496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved the start of `DownloadMonitorService` from the `onStop` lifecycle event to `onPause`, so the service begins slightly earlier—right before the app goes into the background. * Updated `DownloadMonitorService` to start the foreground service immediately, before performing any work or checking the download status. Previously, while the service was checking download status, the app could transition to the background, causing the service to fail to start. Now, the service starts first and performs all checks afterward, ensuring it always launches successfully. If no downloads are active, the service stops itself afterward.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
============================================
+ Coverage 58.87% 58.96% +0.08%
- Complexity 1488 1492 +4
============================================
Files 320 320
Lines 17081 17084 +3
Branches 2128 2128
============================================
+ Hits 10057 10073 +16
+ Misses 5627 5611 -16
- Partials 1397 1400 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4495
DownloadMonitorServicefrom theonStoplifecycle event toonPause, so the service begins slightly earlier—right before the app goes into the background.DownloadMonitorServiceto start the foreground service immediately, before performing any work or checking the download status. Previously, while the service was checking download status, the app could transition to the background, causing the service to fail to start. Now, the service starts first and performs all checks afterward, ensuring it always launches successfully. If no downloads are active, the service stops itself afterward.