Fixed: Someone has reported a crash for ZimFileReader.getFavicon.
#4504
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
force-pushed
the
Fixes#4503
branch
from
d438f5c to
df41ebe
Compare
* Improved the return of the `illustration` item; previously, we were checking first that it had the `illustration` item or not, and then getting the illustration. It calls twice at the library. Now, we are directly getting the illustration like metadata, and if not found, returning null. It will work similarly to the previous, but an extra JNI call is avoided.
MohitMaliFtechiz
force-pushed
the
Fixes#4503
branch
from
df41ebe to
4f8a24c
Compare
Collaborator
Author
|
Now, the PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4503
Improved the return of the
illustrationitem; previously, we were checking first that it had theillustrationitem or not, and then getting the illustration. It calls twice at the library. Now, we are directly getting the illustration like metadata, and if not found, returning null. It will work similarly to the previous, but an extra JNI call is avoided.