-
-
Notifications
You must be signed in to change notification settings - Fork 497
Fixed: Bookmarks for current books are not showing. #4507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* The bookmarks toggle is not showing that current page is bookmarked or not when we opens the ZIM file in custom app, and go into setting and came back to reader.
|
Will release DWDS(kiwix/kiwix-android-custom#257), and Wikimed app after this. |
…this scenario is properly validated and to prevent similar issues in the future.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
============================================
- Coverage 58.63% 58.39% -0.24%
+ Complexity 1501 1497 -4
============================================
Files 320 320
Lines 17237 17246 +9
Branches 2143 2144 +1
============================================
- Hits 10107 10071 -36
- Misses 5726 5773 +47
+ Partials 1404 1402 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kelson42 This PR is ready for review/merge. |
|
Please implement a full e2e test for basic bookmark operations. |
|
@kelson42 Refactored the test cases according to your request. |
testBookmarkToggleForCurrentPagesUI test case to ensure this scenario is properly validated and to prevent similar issues in the future.LibkiwixBookmarkTestto test all scenarios for bookmarks.BookmarkIssue.mp4
BookmarkFix.mp4