Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 24, 2025

  • The bookmarks toggle is not showing whether the current page is bookmarked or not when we open the ZIM file in the custom app, go into settings, and come back to the reader. Now, we are properly setting up the job when all pages are restored, ensuring it works properly in every scenario when the pages are restored in the reader.
  • Added the testBookmarkToggleForCurrentPages UI test case to ensure this scenario is properly validated and to prevent similar issues in the future.
  • Enhanced the LibkiwixBookmarkTest to test all scenarios for bookmarks.
Issue After Fix
BookmarkIssue.mp4
BookmarkFix.mp4

* The bookmarks toggle is not showing that current page is bookmarked or not when we opens the ZIM file in custom app, and go into setting and came back to reader.
@MohitMaliFtechiz MohitMaliFtechiz added this to the 4.0.0 milestone Nov 24, 2025
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft November 24, 2025 09:43
@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Nov 24, 2025

Will release DWDS(kiwix/kiwix-android-custom#257), and Wikimed app after this.

…this scenario is properly validated and to prevent similar issues in the future.
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.39%. Comparing base (0762c2a) to head (2224d7e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...kiwixmobile/core/main/reader/CoreReaderFragment.kt 72.72% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4507      +/-   ##
============================================
- Coverage     58.63%   58.39%   -0.24%     
+ Complexity     1501     1497       -4     
============================================
  Files           320      320              
  Lines         17237    17246       +9     
  Branches       2143     2144       +1     
============================================
- Hits          10107    10071      -36     
- Misses         5726     5773      +47     
+ Partials       1404     1402       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review November 24, 2025 10:29
@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 This PR is ready for review/merge.

@kelson42
Copy link
Collaborator

Please implement a full e2e test for basic bookmark operations.

@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 Refactored the test cases according to your request.

@kelson42 kelson42 merged commit 7254cc7 into main Nov 25, 2025
35 checks passed
@kelson42 kelson42 deleted the bookmark_not_showing_for_current_page branch November 25, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants