-
Notifications
You must be signed in to change notification settings - Fork 11
Updated configure-sdk.sh to have a non-interactive mode #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts for remote vs local, and path/version/branch/commit spec for android/ios SDKs.
amber-klaviyo
approved these changes
Nov 12, 2025
amber-klaviyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few questions to clarify my understanding of the code & expected behaviors, but overall looks good and the questions are non blocking
- Remove --remote flag (no longer needed) - Keep --local/-l as convenience shortcut for default local paths - Make short flags context-aware based on -l flag: * -i/-a with -l → default local paths * -i/-a without -l → master branch - Auto-detect local vs remote from value patterns - Update help documentation with new behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…omment so we can reset to it when not specified.
Contributor
Author
|
@amber-klaviyo FYI I pretty drastically cleaned this up if you wanted to take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The prior implementation of
configure-sdk.shwas interactive only. Its slick but not as convenient for shorthand. It also means AI agents can't run it, because their bash tools don't typically allow answering prompts. This will also make it easier to have the test app's configure script automatically configure the local SDK by invoke this script.It also now "remembers" the prior configured values for the native SDKs by keeping the prior version around in a comment, so for example you could do
./configure-sdk.sh -liato use local on bother platforms, and then./configure-sdk.sh -iawill default you back to the version in the podspec / prior gradle.properties files.Due Diligence
Release/Versioning Considerations
PatchContains internal changes or backwards-compatible bug fixes.MinorContains changes to the public API.MajorContains breaking changes.Changelog / Code Overview
Added arguments for everthing so that you can just run it one-shot instead of having to be interactive. Makes it easier to run quickly, and it makes it possible for AI agents to execute the script for us.
Test Plan
EXAMPLES:
Related Issues/Tickets
Part of ongoing effort to AI-ify the repos, and I want to enable the test-app repo to configure the SDK from its own
configure-sdkscript by calling to this one, when targeting local.