Skip to content

Conversation

@belleklaviyo
Copy link
Contributor

  • Modify permissions library

  • Add bridging to test mock API call

  • Removed unused react-native-permissions library

  • Oh we don't need react-native-geolocation-service either

  • Rename registerForGeofences to registerGeofencing

  • Bridge unregister method

  • Add permission prompting through react-native-permissions, add to example app

  • Support location services in terminated state

  • Only bridge background monitor method to objc, not RN

  • Point to swift SDK feat/geofencing

  • Remove duplicate setup_permissions

  • Bridged android methods (Bridged android methods #283)

Co-authored-by: Evan Masseau <>

  • dispatch to main thread, update pods

  • Remove permissions from Android manifest

  • Add dispatch to main

  • Remove redundant script loading

  • Unversion dependencies

  • Point to updated feat/geofencing swift branch

  • fix path for CI

  • Use Task in KlaviyoBridge async calls

  • Bridge getCurrentGeofences

  • Point pods to feat/geofencing

  • Fix async calls

  • Fix getCurrentGeofences in KlaviyoBridge

  • Added android "getCurrentGeofences" bridge function, tagged it internal also added tests


Co-authored-by: Evan Masseau <>

Description

Due Diligence

  • I have tested this on a simulator/emulator or a physical device, on iOS and Android (if applicable).
  • I have added sufficient unit/integration tests of my changes.
  • I have adjusted or added new test cases to team test docs, if applicable.
  • I am confident these changes are implemented with feature parity across iOS and Android (if applicable).

Release/Versioning Considerations

  • Patch Contains internal changes or backwards-compatible bug fixes.
  • Minor Contains changes to the public API.
  • Major Contains breaking changes.
  • Contains readme or migration guide changes.
    • If so, please merge to a feature branch so documentation updates only go live upon official release.
  • This is planned work for an upcoming release.
    • If no, author or reviewer should account for this in a release plan, or describe why not below.

Changelog / Code Overview

Test Plan

Related Issues/Tickets

* Modify permissions library

* Add bridging to test mock API call

* Removed unused react-native-permissions library

* Oh we don't need react-native-geolocation-service either

* Rename registerForGeofences to registerGeofencing

* Bridge unregister method

* Add permission prompting through react-native-permissions, add to example app

* Support location services in terminated state

* Only bridge background monitor method to objc, not RN

* Point to swift SDK feat/geofencing

* Remove duplicate setup_permissions

* Bridged android methods (#283)

Co-authored-by: Evan Masseau <>

* dispatch to main thread, update pods

* Remove permissions from Android manifest

* Add dispatch to main

* Remove redundant script loading

* Unversion dependencies

* Point to updated feat/geofencing swift branch

* fix path for CI

* Use Task in KlaviyoBridge async calls

* Bridge getCurrentGeofences

* Point pods to feat/geofencing

* Fix async calls

* Fix getCurrentGeofences in KlaviyoBridge

* Added android "getCurrentGeofences" bridge function, tagged it internal
also added tests

---------

Co-authored-by: Evan C Masseau <[email protected]>
Co-authored-by: Evan Masseau <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants