Skip to content

Code styling fixes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Code styling fixes #112

wants to merge 5 commits into from

Conversation

@vmalyk
Copy link

@vmalyk vmalyk commented May 27, 2021

  • Fixed schema path in events.xml
  • Added translatable comment in system.xml
  • Used $block instead $this - Magento code styling guides
  • Fixed layouts - added missed module name for templates - fix for overriding template from theme if it's required (extendability improvement)

@vmalyk
Merge branch 'master' of github.com:klaviyo/magento2-klaviyo into fix…
8b4dd4c 
…/code-styling

# Conflicts:
#	etc/frontend/events.xml
#	view/frontend/templates/analytics/initialize.phtml
@vmalyk
Copy link
Author

vmalyk commented Oct 4, 2021

hey! I've solved conflicts and loos like it's ready for merge.

Please review,
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanallain jordanallain jordanallain approved these changes

@njparadis njparadis njparadis approved these changes

+1 more reviewer

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vmalyk @ihor-sviziev @jordanallain @njparadis