Enhance subscription methods to accept store ID for better context handling #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@DianaSol - could you please add some tests? |
kamidzi-klaviyo-integrations
requested review from
kamidzi-klaviyo-integrations
and removed request for
zchenk
Contributor
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store-Aware Newsletter Sync:
The methods subscribeEmailToKlaviyoList and unsubscribeEmailFromKlaviyoList in Data.php now accept an optional $storeId parameter.
The $storeId is used to fetch the correct Klaviyo list and opt-in settings, ensuring that newsletter subscriptions and unsubscriptions are performed in the context of the correct Magento store.
Manual Testing Steps
Create different lists for differences stores. Place an order from any store and check that subscriber goes into the appropriate list.