-
Notifications
You must be signed in to change notification settings - Fork 55
Add isKlaviyoEnabled to product/viewed.phtml #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0305a56
Add isKlaviyoEnabled check to product/viewed.phtml
GJHypostore ea17829
Merge pull request #1 from GerritJanHypoStore/feature/add-enabled-check
GJHypostore 5931f52
Update CHANGELOG.md.
GJHypostore c98dd29
Revert "Update CHANGELOG.md."
GJHypostore bbf0fd3
Add change to CHANGELOG.md.
GJHypostore 36fc888
Merge remote-tracking branch 'upstream/master'
GJHypostore 8fdfd07
Merge remote-tracking branch 'upstream/master'
GJHypostore c37949b
Add isKlaviyoEnabled check to product/viewed.phtml
GJHypostore 3462bd0
Update CHANGELOG.md.
GJHypostore bcd4b93
Merge remote-tracking branch 'origin/master'
GJHypostore dcf9e78
Merge remote-tracking branch 'upstream/master'
GJHypostore ca72d4d
Add change to CHANGELOG.md.
GJHypostore 288cbdc
Merge branch 'master' into master
smoucka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Klaviyo: Missing API Key Validation Causes Render Issues
The template only checks
isKlaviyoEnabled()but doesn't verify that a public API key exists. The block's_toHtml()method checks both conditions:isKlaviyoEnabled() && getPublicApiKey(). Other templates likeanalytics/initialize.phtmlalso check both. If Klaviyo is enabled but no API key is configured, the template will render and attempt to callgetViewedProductJson()andgetViewedItemJson(), which may cause issues. The check should be:if (!($block->isKlaviyoEnabled() && $block->getPublicApiKey()))to match the block's logic.