Skip to content

Conversation

@smoucka
Copy link
Contributor

@smoucka smoucka commented Sep 3, 2025

Description

Fixes Magento Coding Standard failures in phtml template files.

Adds a blocking CI check that runs phpcs with the Magento Coding Standard (see screenshot below for sample failure). Note this only alerts on severity=10 which is the same as the Magento Marketplace automated technical review. Had to add a separate composer file for this particular CI check because it's incompatible with the dev-develop branch of the PHPCompatibliity tool which is the only way we can get the ongoing maintenance for php 8 compatibility checks.

Manual Testing Steps

Failure
image

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@smoucka smoucka marked this pull request as ready for review September 3, 2025 19:45
@smoucka smoucka requested a review from a team as a code owner September 3, 2025 19:45
@klaviyoit klaviyoit requested a review from zchenk September 3, 2025 19:45
Copy link

@zchenk zchenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smoucka smoucka merged commit 626210a into master Sep 3, 2025
8 checks passed
@smoucka smoucka deleted the fix_4.4.0_tech_failure branch September 3, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants