add phpcs check with Magento Coding Standard to CI #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Magento Coding Standard failures in phtml template files.
Adds a blocking CI check that runs phpcs with the Magento Coding Standard (see screenshot below for sample failure). Note this only alerts on severity=10 which is the same as the Magento Marketplace automated technical review. Had to add a separate composer file for this particular CI check because it's incompatible with the
dev-developbranch of the PHPCompatibliity tool which is the only way we can get the ongoing maintenance for php 8 compatibility checks.Manual Testing Steps
Failure

Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.