Add configurable read timeout support to InMemoryEventDispatcher

[intojhanurag]

Changes

• Updated NewEventDispatcher to append the kncloudevents.WithReadTimeout() option when creating the HTTPEventReceiver.
• Exposed ReadTimeout as part of InMemoryEventDispatcherArgs to allow configuration.

[knative-prow]

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[intojhanurag]

Hey @Leo6Leo , Can you take a look on this PR , if you have a moment ?

[Cali0707]

Hey @intojhanurag thanks for the PR!

I'm not sure this actually meaningfully changes anything in it's current state - as far as I can tell the read timeout is always set here (and is not configurable to users):

eventing/pkg/reconciler/inmemorychannel/dispatcher/controller.go

Line 62 in 161a91a

readTimeout = 15 * time.Minute

cc @creydr @twoGiants do you think we should be exposing config for this somewhere?

[Cali0707]

can you extract this into a constant?

[intojhanurag]

Done !