Skip to content

Conversation

@hius07
Copy link
Member

@hius07 hius07 commented Dec 7, 2025

To be used in colored buttons.


This change is Reviewable

@NiLuJe
Copy link
Member

NiLuJe commented Dec 7, 2025

I'd obviously prefer that with the C implementation in, too ;).

(At a quick glance, it wouldn't look too gnarly to implement, just a bunch of code duplication).

@hius07
Copy link
Member Author

hius07 commented Dec 8, 2025

Looks like it's already there but the color parsing should be fixed:

koreader-base/blitbuffer.c

Lines 3151 to 3152 in b677605

} else if (bb_type == TYPE_BBRGB32) {
const ColorRGB32 color = { .r = c, .g = c, .b = c, .alpha = 0xFF };

Out of my abilities unfortunately.

@NiLuJe
Copy link
Member

NiLuJe commented Dec 8, 2025

Yeah, it already supports every target BB, which is why I mentioned it should be fairly easy (basically the same idea as fill_rect vs. fill_rect_RGB32) ;).

I miiiiight have some time during winter break, but who knows really ;p.

@hius07
Copy link
Member Author

hius07 commented Dec 8, 2025

Lua version works fine on Kindle, frontend PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants