Add Validations for the BulkAPI Params #1557
Conversation
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
rbadagandi1
requested review from
bharathappali
and removed request for
msvinaykumar
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
bharathappali
left a comment
bharathappali
left a comment
There was a problem hiding this comment.
@khansaad Thanks for the PR, I have requested some changes for adding copyrights and java doc, apart from that everything LGTM
| @@ -0,0 +1,95 @@ | |||
| package com.autotune.common.bulk; | |||
There was a problem hiding this comment.
@khansaad Thanks for raising the validations PR. Please kindly add the Copyrights header, as it's a new file.
| import java.time.OffsetDateTime; | ||
| import java.time.format.DateTimeParseException; | ||
|
|
||
| public class BulkServiceValidation { |
There was a problem hiding this comment.
Adding a Javadoc could be a bit helpful for the devs to understand about this class.
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(BulkServiceValidation.class); | ||
|
|
||
| public static ValidationOutputData validate(BulkInput payload, String jobID) throws Exception { |
There was a problem hiding this comment.
Java doc for this and other methods would be helpful as well.
| return errorMessage; | ||
| } | ||
|
|
||
| public static String validateTimeRange(BulkInput.TimeRange timeRange) { |
There was a problem hiding this comment.
Having a java doc would be helpful
| } | ||
|
|
||
|
|
||
| public static String validateDatasourceConnection(String datasourceName) { |
There was a problem hiding this comment.
Having a java doc would be helpful
| return validationOutputData; | ||
| } | ||
|
|
||
| private static ValidationOutputData buildErrorOutput(String errorMsg, String jobID) { |
There was a problem hiding this comment.
Having a java doc would be helpful
Signed-off-by: Saad Khan <[email protected]>
Thanks for pointing that out. Added now. |
4 participants
Description
This PR adds validations for the Bulk API params.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here