Add Bulk validations test #1708
Open
+145
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saad Khan <[email protected]>
chandrams
requested changes
Dec 2, 2025
|
|
||
|
|
||
| @pytest.mark.test_bulk_api_ros | ||
| @pytest.mark.parametrize("start, end, expected_error", [ |
Contributor
There was a problem hiding this comment.
@khansaad Can you update the test documentation with the test scenarios. Also add a description in the PR.
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
…s-test # Conflicts: # tests/scripts/helpers/utils.py
Contributor
Author
|
bulk-test-results.zip |
chandrams
reviewed
Dec 4, 2025
| validate_job_status(response.json()["job_id"], URL, caplog) | ||
|
|
||
|
|
||
| @pytest.mark.test_bulk_api_ros |
Contributor
There was a problem hiding this comment.
Is this marker added in the tests list in the script to run? If not, you can add negative/sanity marker too.
Contributor
Author
There was a problem hiding this comment.
Yes, its added in the pytest.ini file
chandrams
reviewed
Dec 4, 2025
| ("2024-01-01 10:00:00", "2024-01-01T12:00:00Z", "Invalid date format. Must follow ISO 8601 format (YYYY-MM-DDTHH:mm:ss.sssZ) for the jobId:"), # bad format | ||
| ("2025-01-02T12:00:00Z", "2025-01-01T12:00:00Z", "Start time should be before end time for the jobId:"), # start > end | ||
| # less than 24 hours difference | ||
| ("2025-01-01T00:00:00Z", "2025-01-01T10:00:00Z", "Time range must be between 24 hours and 15 days for the jobId:"), |
Contributor
There was a problem hiding this comment.
@khansaad I don't think we should have this time range check, please verify and update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains tests for the validations added as part of PR #1557
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here