-
Notifications
You must be signed in to change notification settings - Fork 62
Add functional tests for the request_id feature #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mvp_demo
Are you sure you want to change the base?
Conversation
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
| request_id = generate_request_id(32) | ||
| temp_file_path = inject_request_id_and_save(result_json_file, request_id) | ||
|
|
||
| response = update_results(temp_file_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add validation to check the logs for the presence of request_id messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Saad Khan <[email protected]>
|
@khansaad Can you please share the test results? |
# Conflicts: # tests/scripts/remote_monitoring_tests/rest_apis/test_update_results.py
|
Description
This PR contains functional tests for the
request_idfeature added as part of the PR #1620Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information