[WIP] adding ratio limit calculations #1704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khansaad
requested changes
Nov 19, 2025
| public static final int SECTION_CRITICAL_SUBSECTION_DATA_SUBSYSTEM_MEMORY_START = 524000; | ||
| public static final int CRITICAL_MEMORY_REQUEST_NOT_SET = 524001; | ||
| public static final int CRITICAL_MEMORY_LIMIT_NOT_SET = 524002; | ||
| public static final int ERROR_NO_RECOMMENDED_REQUEST_FOR_LIMIT_CALCULATION = 225001; |
Contributor
There was a problem hiding this comment.
Need to add these new notification codes in the design doc as well.
For reference: https://github.com/kruize/autotune/blob/master/design/NotificationCodes.md
| public static final String METADATA_PROFILE_FILE_PATH = "metadataProfileFilePath"; | ||
| public static final String METRIC_PROFILE_FILE_PATH = "metricProfileFilePath"; | ||
| public static final String IS_KAFKA_ENABLED = "isKafkaEnabled"; | ||
| public static final String ADJUST_MEM_USAGE = "adjustMemUsage"; |
Contributor
There was a problem hiding this comment.
This flag needs to be added in the crc yaml to control the flow before starting the kruize application
| @@ -0,0 +1,2628 @@ | |||
| package com.autotune.analyzer.recommendations.engine; | |||
Contributor
There was a problem hiding this comment.
This appears to be mistake. We already have this data in the RecommendationEngine class.
We also have the RecommendationConstants class as well.
Please check and revert this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature aims to give users more control over how Kruize calculates resource recommendations, specifically allowing the recommended limits to be different from the recommended requests, while maintaining the user's existing ratio between them.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here