Skip to content

Conversation

@Misha6Sharma
Copy link

This PR updates several deprecated Kustomize fields across multiple components to reduce warnings during kustomize build
Changes included in the following field:
Replacing commonLabels with labels
Replacing bases with resources
Replacing patchesStrategicMerge with patches
I didn’t convert vars to replacements yet since that feature is still experimental and could affect how the manifests build.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Misha6Sharma added 2 commits November 5, 2025 01:08
@Misha6Sharma Misha6Sharma force-pushed the fix-kustomize-warnings branch from 97a38c9 to 02ab07d Compare November 4, 2025 19:44
@hbelmiro
Copy link

hbelmiro commented Nov 4, 2025

/ok-to-test

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Nov 5, 2025

Hello @Misha6Sharmathese and thank you for the PR. The files are synchronized here via scripts. You need to fix it upstream in kubeflow/dashboard, kubeflow/pipelines kubeflow/katib etc. to change the source. But you can use this PR to test your upstream changes platform wide.

@Misha6Sharma
Copy link
Author

Thanks for clarifying , I didnt know these files are synced from the upstream repos
Will move the updates to the respective repo and will use the same to verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants