Skip to content

Conversation

@kunal-511
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Update split-istio-packages script to extract ztunnel resources
Update synchronize-istio-manifests to generate ztunnel manifests with ambient mode enabled

🐛 Related Issues

#3246

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@kunal-511
Copy link
Contributor Author

/retest

1 similar comment
@kunal-511
Copy link
Contributor Author

/retest

@juliusvonkohout juliusvonkohout force-pushed the ztunnel-manifests-generation branch from 7763e4b to 771f702 Compare November 17, 2025 16:26
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Nov 17, 2025

Thank you for the PR. I think github was a bit slow which lead to failed tests. I retriggered all tests. Probably you can revert the Katib timeout.

Signed-off-by: kunal-511 <[email protected]>
@juliusvonkohout
Copy link
Member

You cal also always retest with /retest if needed

Enable debugging options in free-disk-space.sh

Signed-off-by: Julius von Kohout <[email protected]>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Nov 17, 2025
Removed 'apt-get autoremove' command from the script.

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Updated checkout action version and added disk space cleanup step.

Signed-off-by: Julius von Kohout <[email protected]>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Nov 17, 2025

And i am still wondering why the DEX test is so unreliable https://github.com/kubeflow/manifests/actions/runs/19438990652/job/55622642323 is so unreliable

@juliusvonkohout
Copy link
Member

Lets wait with merging until #3274 (comment) is resolved

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Nov 18, 2025

Thank you

/lgtm
/approve

and here is the istio PR for your /lgtm #3275

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout mentioned this pull request Nov 18, 2025
@google-oss-prow google-oss-prow bot merged commit 482c179 into kubeflow:master Nov 18, 2025
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants