Synchronize trainer manifests 2.1.0 #3281
Conversation
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
This tag change looks strange @kunal-511 @andreyvelich
| images: | ||
| - name: ghcr.io/kubeflow/trainer/trainer-controller-manager | ||
| newTag: v2.0.1 | ||
| newTag: latest |
There was a problem hiding this comment.
This tag change looks strange @kunal-511 @andreyvelich
There was a problem hiding this comment.
That does not look right. Why is it not just added to the default-editor.
| # Add data cache image tags | ||
| images: | ||
| - name: ghcr.io/kubeflow/trainer/dataset-initializer | ||
| newTag: latest |
There was a problem hiding this comment.
also here the tag should not be latest
There was a problem hiding this comment.
This role should aggregate to kubeflow-edit
| image: ghcr.io/kubeflow/trainer/dataset-initializer | ||
| env: | ||
| - name: CACHE_IMAGE | ||
| value: "ghcr.io/kubeflow/trainer/data-cache:latest" |
There was a problem hiding this comment.
the tag is not right
There was a problem hiding this comment.
Should this be added to the default-editor ?
|
/hold |
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
|
i will open a fresh PR. |
|
continued in #3282 |
@andreyvelich @yiminghub2024 please review. I think some tags were changed to latest. whic might not be right. Otherwise i see the namespace lws-system which is then redirected to kubeflow-system