Update default Azure VM SKU to Standard_D2ds_v5

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Follows up on #6017 to update remaining default Azure VM SKUs used in testing and templates since the current choices are now deprecated.

Overall:

• Standard_D2s_v3 -> Standard_D2ds_v5.
• Standard_D4s_v3 -> Standard_D4s_v5.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

See the migration guide for more information. The current SKUs will be phased out in 2028, so this isn't urgent.

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

NONE

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/test pull-cluster-api-provider-azure-e2e

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.41%. Comparing base (e5e057a) to head (26353b5).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5996   +/-   ##
=======================================
  Coverage   44.40%   44.41%           
=======================================
  Files         280      280           
  Lines       25377    25377           
=======================================
+ Hits        11269    11271    +2     
+ Misses      13295    13293    -2     
  Partials      813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mboersma]

/test pull-cluster-api-provider-azure-e2e-optional

[mboersma]

/retitle [WIP] Update default Azure VM SKUs used in testing and templates

AKS tests failed with:
The Virtual Machine size Standard_D2s_v5 does not support Ephemeral OS disk.

[mboersma]

/hold

In conjunction with this, we should ensure there is increased quota for this SKU family in expected test regions. I'll do that if this passes.

[mboersma]

/retest

[k8s-ci-robot]

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-e2e-optional	4bb058e	link	false	/test pull-cluster-api-provider-azure-e2e-optional
pull-cluster-api-provider-azure-apiversion-upgrade	26353b5	link	true	/test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jackfrancis]

We don't have quota for the v5 SKU, so let's table this.

/close

[k8s-ci-robot]

@jackfrancis: Closed this PR.

Details

In response to this:

We don't have quota for the v5 SKU, so let's table this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.