🌱 taint propagation: e2e coverage via md rollout test #12966
Merged
+224
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
Member
Author
|
/test help |
Contributor
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
20 tasks
Member
Author
|
Unrelated flake? /retest |
k8s-ci-robot
added
the
needs-rebase
chrischdi
force-pushed
the
pr-implement-taint-propagation-e2e
branch
from
8943c0c to
62d0372
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
k8s-ci-robot
removed
the
needs-rebase
chrischdi
force-pushed
the
pr-implement-taint-propagation-e2e
branch
from
62d0372 to
0509f99
Compare
Member
Author
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
chrischdi
force-pushed
the
pr-implement-taint-propagation-e2e
branch
from
0509f99 to
cfad6fc
Compare
k8s-ci-robot
added
size/L
Member
Author
|
/test pull-cluster-api-e2e-main-gke /retitle 🌱 taint propagation: e2e coverage via md rollout test |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
Thank you very much! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 3fee97604d0c865aad43958fc591f39bcb773819
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: c5237cc4c44abee951ed5dcf7cd1057e168ce365
|
test/e2e/md_rollout.go
Outdated
| NodeTaints: wantNodeTaints, | ||
| }) | ||
|
|
||
| Byf("Verify in-place propagation when removing an Always taint from the nodes") |
Member
There was a problem hiding this comment.
should this be
Suggested change
| Byf("Verify in-place propagation when removing an Always taint from the nodes") | |
| Byf("Verify in-place propagation when removing preExisting Always and OnInitialization taint from the nodes") |
test/e2e/md_rollout_test.go
Outdated
| . "github.com/onsi/ginkgo/v2" | ||
| ) | ||
|
|
||
| var _ = Describe("When testing MachineDeployment rolling upgrades", func() { |
Member
There was a problem hiding this comment.
may be
Suggested change
| var _ = Describe("When testing MachineDeployment rolling upgrades and in-place taint propagation", func() { |
k8s-ci-robot
removed
the
lgtm
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 777943ecf8a79b8089b9574a2aa9f509f3dd7c48
|
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
alicefr
pushed a commit
to alicefr/cluster-api
that referenced
this pull request
Nov 14, 2025
…s#12966) * taints: add e2e via md-rollout test * taints: Refer the proposal from the book * e2e: also check no rollout happened * Review fixes and fix no-rollout check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements e2e tests for taint propagation feature: #12908
TODO:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area e2e-testing