Update golangci-lint version and config with linters and formatters

[afbjorklund]

The list of enabled and disabled checks is not well maintained, so it stops all version upgrades.

$ make lint GOLINT_VERSION=v2.3.1
...
94 issues:
* revive: 94

$ make lint GOLINT_VERSION=v2.6.1
...
99 issues:
* revive: 99

• ci: migrate golangci lint to v2 #20658
• build: address all lint issues by v2 #20804

The "gofmt" and "goimports" formatters were not enabled in golint, only as separate make targets.

$ make gofmt
cmd/minikube/cmd/config/view.go
pkg/minikube/assets/addons_test.go
pkg/minikube/assets/vm_assets.go
pkg/minikube/download/licenses.go
test/integration/iso_test.go
make: *** [Makefile:488: gofmt] Error 1
$ make goimports
cmd/minikube/cmd/config/view.go
pkg/minikube/assets/addons_test.go
pkg/minikube/assets/vm_assets.go
pkg/minikube/download/licenses.go
pkg/minikube/tunnel/route_windows_test.go
test/integration/iso_test.go
make: *** [Makefile:501: goimports] Error 1

Make one minimal config, with only the basics. And one maximal with all linters (but no settings).

min

$ make lint GOLINT_VERSION=v2.6.1 GOLINT_CONFIG=.golangci.min.yaml
0 issues.

max

$ make lint GOLINT_VERSION=v2.6.1 GOLINT_CONFIG=.golangci.max.yaml
365 issues:

• errcheck: 167
• gocritic: 7
• gofmt: 1
• revive: 158
• staticcheck: 31
• unparam: 1

---

Enabling all the "revive" rules has an enormous amount of "issues", so that is not really recommended:

+ settings:
+ revive:
+ enable-all-rules: true
* revive: 10407

The project does not have the resources to maintain the inclusion / exclusion lists needed properly...

The above numbers are without vendored code, in third_party and in vendor/github.com/docker/machine

This double standard is missing issues in code, and is stopping the integration of libmachine into minikube.

[k8s-ci-robot]

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-docker-crio-linux-x86-64	561bf41	link	true	/test integration-docker-crio-linux-x86-64
integration-docker-docker-linux-x86-64	561bf41	link	true	/test integration-docker-docker-linux-x86-64
integration-docker-containerd-linux-x86-64	561bf41	link	true	/test integration-docker-containerd-linux-x86-64
integration-kvm-docker-linux-x86-64	561bf41	link	true	/test integration-kvm-docker-linux-x86-64
integration-kvm-crio-linux-x86-64	561bf41	link	true	/test integration-kvm-crio-linux-x86-64
integration-kvm-containerd-linux-x86-64	561bf41	link	true	/test integration-kvm-containerd-linux-x86-64
integration-none-docker-linux-x86-64	561bf41	link	true	/test integration-none-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[medyagh]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment