add new metadata LearningPeriodMetadataKey

[matthyx]

Summary by CodeRabbit

• Refactor
  • Reorganized and expanded internal metadata handling structures to improve code organization and extensibility.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ddb0c642-acf2-4331-91d3-7ddae8394ef5

📥 Commits

Reviewing files that changed from the base of the PR and between 694a811 and e47bc13.

📒 Files selected for processing (1)

• instanceidhandler/v1/helpers/keys.go

---

📝 Walkthrough

Walkthrough

The pull request reorganizes metadata key constants in instanceidhandler/v1/helpers/keys.go by introducing new keys (cloud-account-identifier, cluster, host-id, host-type, learning-period) and restructuring the declaration positions of existing ones to eliminate duplicates.

Changes

Cohort / File(s)	Summary
Metadata Keys Reorganization instanceidhandler/v1/helpers/keys.go	Added new metadata key constants and relocated existing keys (RelatedKindMetadataKey, RelatedNameMetadataKey, RelatedNamespaceMetadataKey, HostTypeMetadataKey, ClusterMetadataKey, CloudAccountIdentifierMetadataKey, RegionMetadataKey, HostIDMetadataKey) to avoid duplicate declarations and improve constant organization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• rename name & kind keys #146: Modifies the same metadata key constants related to Kind/Name reorganization in the same file.
• rename aws key #147: Updates cloud-account-identifier key constants (renaming AWSAccountIDMetadataKey to CloudAccountIdentifierMetadataKey) in the same file.
• added new metadata keys #145: Modifies the same file and adds/relocates cluster, host-type, host-id, region, and cloud/account identifier key constants.

Suggested reviewers

• YakirOren

Poem

🐰 Constants organized with care,
Keys aligned without despair,
Metadata dancing in their place,
No duplicates to slow the race! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions adding 'LearningPeriodMetadataKey', which is indeed one of the changes, but the changeset also reorganizes and relocates multiple other metadata key constants. The title only covers a partial aspect of the main change rather than the primary objective.	Consider revising the title to reflect the broader scope: 'Reorganize metadata key constants and add LearningPeriodMetadataKey' to better represent all significant changes in the changeset.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch key

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success