Skip to content

Conversation

@slonka
Copy link
Contributor

@slonka slonka commented Nov 13, 2025

We were missing a namespace and you get then:

Error from server (NotFound): error when creating "STDIN": namespaces "kuma-demo" not found

because we never created this NS on global (see guide up until the change).

Did you sign your commit? Instructions yes

Have you read Contributing guidelines? yes

Copilot AI review requested due to automatic review settings November 13, 2025 14:35
@slonka slonka requested a review from a team as a code owner November 13, 2025 14:35
@slonka slonka requested review from Automaat, Icarus9913 and schogges and removed request for a team November 13, 2025 14:35
Copilot finished reviewing on behalf of slonka November 13, 2025 14:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a missing namespace creation step to federation documentation guides. The change prevents users from encountering a "namespaces 'kuma-demo' not found" error when following the federation setup instructions.

  • Adds instruction to create kuma-demo namespace on the global control plane before applying policies
  • Ensures namespace exists before subsequent policy operations that reference it
  • Maintains consistency across both federation guide variants

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/_src/guides/federate.md Adds namespace creation step before policy application section
app/_src/guides/federate-kv.md Adds namespace creation step before policy application section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### Apply policy on global control plane
First we need to create a namespace on global control plane to match the namespace of demo application in zone control plane:
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: Missing article "the" before "demo application". The sentence should read "namespace of the demo application" for correct grammar.

Suggested change
First we need to create a namespace on global control plane to match the namespace of demo application in zone control plane:
First we need to create a namespace on global control plane to match the namespace of the demo application in zone control plane:

Copilot uses AI. Check for mistakes.

### Apply policy on global control plane

First we need to create a namespace on global control plane to match the namespace of demo application in zone control plane:
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: Missing article "the" before "demo application". The sentence should read "namespace of the demo application" for correct grammar.

Suggested change
First we need to create a namespace on global control plane to match the namespace of demo application in zone control plane:
First we need to create a namespace on global control plane to match the namespace of the demo application in zone control plane:

Copilot uses AI. Check for mistakes.
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 76f4c7b
🔍 Latest deploy log https://app.netlify.com/projects/kuma/deploys/6915ec9d584e2b00082a7705
😎 Deploy Preview https://deploy-preview-2483--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 9 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant