Skip to content

Conversation

@kurone-kito
Copy link
Owner

@kurone-kito kurone-kito commented Sep 30, 2025

Features

Refactors

  • 282bd1b: Added the conditional check for docker cli completions
  • f601f2e: Removed some deprecated taps: blacktop/tap

Other updates

Summary by CodeRabbit

  • Documentation
    • Updated Code of Conduct to Contributor Covenant 3.0 (EN and ZH) with clearer reporting, enforcement, and scope.
    • Removed README entries for myside, Skype, and IBM Plex.
  • Bug Fixes
    • Prevented zsh errors when Docker completions are missing.
    • Updated Homebrew command-not-found handler path.
  • Chores
    • Upgraded lint workflow checkout action and stale bot (weekly schedule; 14-day close window).
    • Removed deprecated taps/casks from Brewfiles.

@kurone-kito kurone-kito self-assigned this Sep 30, 2025
Copilot AI review requested due to automatic review settings September 30, 2025 08:49
@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Walkthrough

Updates policies and CI/config files: adopts Contributor Covenant 3.0 in English and Chinese, adjusts GitHub workflow versions/schedules, refines zsh initialization for Docker and Homebrew paths, and removes several taps/casks with matching README list deletions.

Changes

Cohort / File(s) Summary of Changes
Code of Conduct (v3.0 adoption)
.github/CODE_OF_CONDUCT.md, .github/CODE_OF_CONDUCT.zh.md
Replaced prior conduct docs with Contributor Covenant 3.0 structure, including new sections for encouraged/restricted behaviors, reporting, remediation, and an enforcement ladder; updated attributions/resources.
CI Workflows
.github/workflows/lint.yml, .github/workflows/stale.yml
Lint: bump actions/checkout to v5. Stale: change schedule to Mondays 00:00, bump actions/stale to v10, extend days-before-close to 14.
Shell init (zsh)
.zsh.d/docker, .zsh.d/homebrew
Docker completions now conditional on directory existence; Homebrew command-not-found handler path updated to .../Library/Homebrew/command-not-found/handler.sh.
Brew config cleanup
Brewfile, min.Brewfile, README.md
Removed tap blacktop/tap and casks mysides, font-ibm-plex, skype; matching README entries deleted.

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

enhancement

Poem

I thump my paws in tidy cheer—
New rules penned clear, our paths sincere.
Cron ticks softly, Mondays call,
Brew taps trimmed, fewer casks for all.
Zsh whispers, checks then flows—
A rabbit nods: on it goes. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not include the required HTML comment block at the top linking to the contributing guidelines as specified by the repository’s description template, so the standardized guidance for contributors is missing. Please prepend the description with the HTML comment block from the repository’s template that references the CONTRIBUTING.md documents in English, Japanese, and Chinese to ensure contributors see the required pre-submission instructions.
Title Check ❓ Inconclusive The title “Cumulative updates” is overly generic and does not convey the primary purpose or key changes of this pull request, making it difficult for reviewers to understand what has been updated at a glance. Please update the title to clearly and concisely reflect the main change, for example specifying the Code of Conduct upgrade, workflow version bumps, or removed installations in a brief phrase.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cumulative-updates

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efe8f82 and be1360c.

📒 Files selected for processing (9)
  • .github/CODE_OF_CONDUCT.md (1 hunks)
  • .github/CODE_OF_CONDUCT.zh.md (1 hunks)
  • .github/workflows/lint.yml (1 hunks)
  • .github/workflows/stale.yml (1 hunks)
  • .zsh.d/docker (1 hunks)
  • .zsh.d/homebrew (1 hunks)
  • Brewfile (0 hunks)
  • README.md (0 hunks)
  • min.Brewfile (0 hunks)
💤 Files with no reviewable changes (3)
  • README.md
  • Brewfile
  • min.Brewfile
🔇 Additional comments (16)
.zsh.d/docker (1)

6-10: LGTM! Good defensive programming.

The conditional check ensures Docker CLI completions are only configured when the completions directory exists, preventing errors when Docker Desktop is not installed.

.github/CODE_OF_CONDUCT.zh.md (5)

1-10: LGTM! Header and pledge sections are well-structured.

The header correctly identifies this as the Contributor Covenant with proper language navigation, and the pledge section clearly articulates the community's commitment to inclusivity and respect.


11-24: LGTM! Encouraged behaviors section is comprehensive.

The section clearly outlines positive community behaviors with appropriate cultural sensitivity notes, consistent with Contributor Covenant 3.0 standards.


25-53: LGTM! Restricted behaviors section is thorough.

The prohibited behaviors are clearly defined with appropriate categorization, including the "Other Restrictions" subsection for additional scenarios.


96-110: LGTM! Scope and attribution sections are complete.

The scope clearly defines applicability, and the attribution properly credits Contributor Covenant 3.0 with correct licensing information (CC BY-SA 4.0) and references to external resources and Mozilla's contribution.


54-95: LGTM! Reporting and enforcement framework is comprehensive; reporting links verified (HTTP 200).

.github/CODE_OF_CONDUCT.md (5)

1-10: LGTM! Header and pledge sections are properly structured.

The title correctly identifies this as Contributor Covenant 3.0, and the pledge section articulates clear commitments to community inclusivity and equity.


12-25: LGTM! Encouraged behaviors section is comprehensive.

The section clearly outlines positive community behaviors with appropriate acknowledgment of cultural differences, consistent with Contributor Covenant 3.0 standards.


27-45: LGTM! Restricted behaviors section is thorough.

The prohibited behaviors are clearly enumerated with appropriate categorization, including harassment, character attacks, stereotyping, and other restrictions. Structure aligns well with the Chinese version.


47-81: LGTM! Reporting and enforcement framework is well-defined.

The reporting mechanisms and enforcement ladder are comprehensive and consistent with both Contributor Covenant 3.0 and the Chinese version. The 4-tier system clearly defines events, consequences, and repair actions for each level.


83-95: LGTM! Scope and attribution sections are complete.

The scope clearly defines where the Code of Conduct applies, and the attribution properly credits Contributor Covenant 3.0 with correct licensing (CC BY-SA 4.0), resource links, and acknowledgment of Mozilla's influence.

.zsh.d/homebrew (1)

23-27: Approve command-not-found handler integration.

The new handler path (Library/Homebrew/command-not-found/handler.sh) matches Homebrew’s official documentation (docs.brew.sh) and the existence check preserves backward compatibility.

.github/workflows/stale.yml (3)

4-4: LGTM! Stale check frequency reduced to weekly.

The schedule change from daily (0 0 * * *) to weekly on Mondays (0 0 * * 1) reduces the frequency of stale checks, which can help reduce noise and unnecessary notifications.


14-14: LGTM! Extended grace period before closing.

Increasing days-before-close from 7 to 14 days provides a longer window for contributors to respond before items are automatically closed, which is a reasonable policy adjustment that complements the reduced check frequency.


12-12: Confirm runner compatibility for actions/stale@v10

Stale action upgraded to v10.0.0 (released Sep 4, 2025) includes a breaking change: upgraded to Node.js 24 and requires GitHub Actions runner v2.327.1 or later for compatibility (github.com). Ensure your runners meet this requirement.

.github/workflows/lint.yml (1)

11-11: Approve actions/checkout@v5 upgrade
Confirmed v5.0.0 bumps the action runtime to Node 24 and requires GitHub Actions Runner ≥ v2.327.1—GitHub-hosted runners already satisfy this; ensure any self-hosted runners are updated accordingly.


🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kurone-kito kurone-kito added the enhancement New feature or request label Sep 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements cumulative updates across the repository, removing deprecated applications and taps, updating configurations, and migrating to newer versions of various tools.

  • Removed deprecated tap blacktop/tap and multiple app installations (IBM Plex font, Microsoft Skype, mysides)
  • Updated Homebrew command-not-found handler path and added conditional check for Docker CLI completions
  • Migrated to newer versions of GitHub Actions and updated Code of Conduct to version 3.0

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
min.Brewfile Removed deprecated tap and app installations
README.md Updated documentation to reflect removed applications
Brewfile Removed deprecated tap and app installations
.zsh.d/homebrew Updated command-not-found handler path
.zsh.d/docker Added conditional check for Docker completions directory
.github/workflows/stale.yml Updated action version and adjusted cron schedule
.github/workflows/lint.yml Updated checkout action version
.github/CODE_OF_CONDUCT.zh.md Updated to Contributor Covenant 3.0
.github/CODE_OF_CONDUCT.md Updated to Contributor Covenant 3.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cask 'mysides'

# Shell
brew 'blacktop/tap/lporg'
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package 'blacktop/tap/lporg' is still being installed but the 'blacktop/tap' tap was removed on line 15. This will cause a brew installation failure since the tap is no longer available.

Copilot uses AI. Check for mistakes.
cask 'mysides'

# Shell
brew 'blacktop/tap/lporg'
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package 'blacktop/tap/lporg' is still being installed but the 'blacktop/tap' tap was removed on line 15. This will cause a brew installation failure since the tap is no longer available.

Copilot uses AI. Check for mistakes.
@kurone-kito kurone-kito merged commit e40b649 into master Sep 30, 2025
4 checks passed
@kurone-kito kurone-kito deleted the cumulative-updates branch September 30, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants