Respect the current formatting for new text entry#80
Open
jbmorley wants to merge 2 commits intokyle-n:mainfrom
Open
Respect the current formatting for new text entry#80jbmorley wants to merge 2 commits intokyle-n:mainfrom
jbmorley wants to merge 2 commits intokyle-n:mainfrom
Conversation
Author
|
Here's the behavior I've been seeing (thanks to @gingerbeardman for the bug report and video): ea28919b53ad818f.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing text jumping during typing after applying formatting with different font sizes. Reproducing this is a little fiddly, but seems to stem from the fact that the typing attributes don't reliably pick up the style from the underlying NSAttributedString.
This change explicitly sets the typing attributes to match the attributes at the insertion point, failing over to the default editor font if the editor is empty.