Bubble level change color when reach threshold #3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I left a few minor comments but functionality wise that looks great |
kylecorry31
reviewed
Nov 24, 2025
| getString(R.string.pref_bubble_level_threshold), | ||
| { prefs.threshold.toInt() }, | ||
| { prefs.threshold = it.toFloat() }, | ||
| minValue = 1, |
Owner
There was a problem hiding this comment.
Is it possible to make the minimum value 0? That way if a user doesn't want it to show they can set it to 0 and it should never appear
| import com.kylecorry.trail_sense.R | ||
| import com.kylecorry.trail_sense.shared.preferences.PreferencesSubsystem | ||
|
|
||
| class BubbleLevelPreferences(private val context: Context) : IBubbleLevelPreferences { |
Owner
There was a problem hiding this comment.
Can this extend the PreferenceRepo as well?
(that removes the need to define cache)
| { prefs.threshold = it.toFloat() }, | ||
| minValue = 1, | ||
| maxValue = 10, | ||
| formatValue = { getString(R.string.degree_format, it.toFloat()) } |
Owner
There was a problem hiding this comment.
Can the FormatService be used?
Available with AppServiceRegistry.get()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview
Adds a user-configurable threshold setting for the Bubble Level tool in settings. (Persists across app sessions)
The bubble background color changes based on this custom threshold.
Changes:
BubbleLevelPreferencesto store threshold setting (default: 2°)BubbleLevelSettingsFragmentwith number pickerBubbleLevelbased on thresholdRelated Issue
The following PR includes the functionality requested in issue #3224
Checklist
Screenshots
screen-20251124-182948.mp4