fix: normalize hostnames in version dropdown matching#1978
Open
Pittu-Sharma wants to merge 4 commits into
Open
fix: normalize hostnames in version dropdown matching#1978Pittu-Sharma wants to merge 4 commits into
Pittu-Sharma wants to merge 4 commits into
Conversation
Signed-off-by: pittu sharma <pittusharma47@gmail.com>
This fix ensures that the version dropdown correctly identifies the current documentation version when the site is accessed via 'www.kyverno.io' (or any other hostname with a 'www.' prefix). The matching logic now normalizes both the browser's current hostname and the hostnames defined in the documentation versions list by stripping 'www.' and converting to lowercase. Fixes: kyverno#1929 Signed-off-by: pittu sharma <pittusharma47@gmail.com>
|
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
Contributor
Author
Thanks! I have read the guidelines and confirmed that all my commits are signed off. The checks are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#1929
Proposed Changes
When the Kyverno website is accessed via a hostname with a
www.prefix (e.g.,www.kyverno.io), the version dropdown incorrectly identifies the current documentation version asmaininstead of the latest stable release. This happens because the exact matching logic fails to recognizewww.kyverno.ioas an alias for the stable production site.This PR resolves the issue by improving the version detection utility in
src/utils/versions.ts:www.prefix and converting to lowercase.documentationVersionslist in the same manner.www.kyverno.iocorrectly maps to the canonicalkyverno.ioentry, while preserving the intended behavior for subdomains likemain.kyverno.ioand local development onlocalhost.Checklist