fix: enforce type in feedback_config, reject unknown fields, add validation tests (#31802)
#2056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixed
Fixes langchain-ai/langchain#31802
This PR improves validation in FeedbackConfigModel to ensure stricter feedback configuration and better error handling.
Changes:
Tests
All tests pass successfully:
pytest tests/evaluation/test_feedback_config.py -v
8 passed in 0.02s
All validation scenarios covered (valid, invalid, missing type, extra fields, literal enforcement).
Notes
This change is backward-compatible and designed to work seamlessly alongside existing pydantic.v1 usage in the repository.