chore: Xin/improve unnamed runtree naming #2124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneJinXin
force-pushed
the
xin/improve-unnamed-runtree-naming
branch
from
c962563 to
431ceae
Compare
jacoblee93
reviewed
Nov 13, 2025
| values["name"] = "Unnamed" | ||
| name = None | ||
| try: | ||
| import inspect |
Collaborator
There was a problem hiding this comment.
Imports like this should be top level right?
Contributor
Author
There was a problem hiding this comment.
it should be rare case we even need to enter "make a name" mode. so i don't worry too much about perf.
yeah inspect can go to top
jacoblee93
reviewed
Nov 13, 2025
| import os | ||
|
|
||
| # Look up the stack, skipping internal frames | ||
| for frame_info in inspect.stack()[1:8]: |
Collaborator
There was a problem hiding this comment.
Any perf concerns here?
Contributor
Author
There was a problem hiding this comment.
it should be rare case we even need to enter "make a name" mode. i.e, this conditoin should not be entered.
so i don't worry too much about perf.
jacoblee93
reviewed
Nov 13, 2025
| name = frame_locals["self"].__class__.__name__ | ||
| break | ||
| elif "cls" in frame_locals: | ||
| name = frame_locals["cls"].__name__ |
Collaborator
There was a problem hiding this comment.
I don't know enough about Python to know if this is a good idea
Is there no easier fallback?
Contributor
Author
There was a problem hiding this comment.
there's try catch so at least it won't error, no better fallback afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://langchain.slack.com/archives/C04GMBZ9Y1Y/p1763061096088929