Revert patch causing timestamps to be received with the incorrect endianness#26
Open
spencercw wants to merge 1 commit intolarku:masterfrom
Open
Revert patch causing timestamps to be received with the incorrect endianness#26spencercw wants to merge 1 commit intolarku:masterfrom
spencercw wants to merge 1 commit intolarku:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting #15
My assumption is the original author was writing the timestamp with the wrong endianness in the first place, which is easily done when not using bitstreams (see http://www.jenkinssoftware.com/raknet/manual/creatingpackets.html). The original patch causes the endianness to be inverted twice when using bitstreams, breaking reception of these timestamps.