Replace react-loadable with @loadable/component #6972
+1
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
Member
|
@adity1raut merge conflicts , please look over them |
adity1raut
force-pushed
the
react-loadable
branch
from
2877732 to
9c6b5ff
Compare
Contributor
|
🚀 Preview for commit b493f11 at: https://6904be8d178fc323d8fe855d--layer5.netlify.app |
Author
|
PTAL @Namanv0509 |
Member
Rajesh-Nagarajan-11
left a comment
Rajesh-Nagarajan-11
left a comment
There was a problem hiding this comment.
You mentioned in the PR description that react-loadable was removed from package.json, but I don’t see any such removal in the file.
Signed-off-by: Saloni Tarone <[email protected]>
adity1raut
force-pushed
the
react-loadable
branch
from
b493f11 to
2dedf34
Compare
Author
|
PTAL @Rajesh-Nagarajan-11 |
Contributor
|
🚀 Preview for commit 2dedf34 at: https://690dcbd52ec572d4d258e4ca--layer5.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the project dependencies and code to remove the deprecated
react-loadablepackage and use@loadable/componentinstead. This change ensures that the project uses a maintained library for dynamic imports and code splitting.Changes Made
react-loadablefrompackage.jsonreact-loadablein the codebase with@loadable/componentRelated Issue
Fixes #6868